-
Notifications
You must be signed in to change notification settings - Fork 282
feat(ui5-popover): implement resizable popover #12623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TeodorTaushanov
wants to merge
44
commits into
main
Choose a base branch
from
popover_resize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🚀 Deployed on https://pr-12623--ui5-webcomponents-preview.netlify.app |
alexandar-mitsev
requested changes
Nov 24, 2025
Member
alexandar-mitsev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- during the resize, the arrow constantly flickers. minor issue, but quite visible.
- sometimes the resize arrow is on the wrong side. This happens if the opener is longer than the popover - e.g. in a very long date picker input, the popover is in leftmost position and the arrow is also in the left bottom arrow. To reproduce set resizable to true on the datepicker input (second input) on test/pages/Popover.html. Same is reproducible in the "Horizontal Align" test section in Popover.html
- during resize - if you do it quick, the resizing starts to lag. Can stay like that, but if possible to fix, will be better
Member
Author
|
Member
Author
|
Stoev
reviewed
Nov 25, 2025
packages/website/docs/_samples/main/Popover/Resizable/sample.html
Outdated
Show resolved
Hide resolved
packages/website/docs/_samples/main/Popover/Resizable/sample.html
Outdated
Show resolved
Hide resolved
Stoev
reviewed
Nov 26, 2025
Stoev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my UA perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: BGSOFUIRODOPI-3384
Certain styles for slotted elements in the footer and header are overridden, similar to how it is done in the UI5 dialog.